[webkit-reviews] review granted: [Bug 36602] [chromium] linux: prefer the "hinting" fontconfig preference. : [Attachment 51641] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 25 09:50:34 PDT 2010


David Levin <levin at chromium.org> has granted Adam Langley <agl at chromium.org>'s
request for review:
Bug 36602: [chromium] linux: prefer the "hinting" fontconfig preference.
https://bugs.webkit.org/show_bug.cgi?id=36602

Attachment 51641: patch
https://bugs.webkit.org/attachment.cgi?id=51641&action=review

------- Additional Comments from David Levin <levin at chromium.org>

> diff --git a/WebCore/platform/graphics/chromium/FontPlatformDataLinux.cpp
b/WebCore/platform/graphics/chromium/FontPlatformDataLinux.cpp
> +    default:
> +	   paint->setHinting((SkPaint::Hinting) m_style.hintStyle);

Please use C++ style casting like this: 
  paint->setHinting(static_cast<SkPaint::Hinting>(m_style.hintStyle));


More information about the webkit-reviews mailing list