[webkit-reviews] review requested: [Bug 36533] [Qt] Compilation error on Qt for Embedded Linux built with -qconfig small : [Attachment 51647] add #ifndef QT_NO_SETTINGS ~ #endif

[bugzilla-daemon at webkit.org]

Tasuku Suzuki <tasuku.suzuki at nokia.com> has asked  for review:
Bug 36533: [Qt] Compilation error on Qt for Embedded Linux built with -qconfig
small
https://bugs.webkit.org/show_bug.cgi?id=36533

Attachment 51647: add #ifndef QT_NO_SETTINGS ~ #endif
https://bugs.webkit.org/attachment.cgi?id=51647&action=review

------- Additional Comments from Tasuku Suzuki <tasuku.suzuki at nokia.com>
> This seems specific to inspector settings. Why woudl it be called
NO_SETTINGS? 
> I expected this to deal with Settings.h  Please explain what you're tryign to

> do in the ChangeLog.

We need to check if QSettings is available with the macro QT_NO_SETTINGS.
If QSettings is disabled by Qt, inspector should not get/set settings.