[webkit-reviews] review requested: [Bug 36589] [Qt] GraphicsLayer: Timing functions don't work with transitions : [Attachment 51621] Fixes the timing functions in transform transitions with AC

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 25 03:57:19 PDT 2010


Kim Grönholm <kim.gronholm at nomovok.com> has asked  for review:
Bug 36589: [Qt] GraphicsLayer: Timing functions don't work with transitions
https://bugs.webkit.org/show_bug.cgi?id=36589

Attachment 51621: Fixes the timing functions in transform transitions with AC
https://bugs.webkit.org/attachment.cgi?id=51621&action=review

------- Additional Comments from Kim Grönholm <kim.gronholm at nomovok.com>
If the animation value doesn't have timing function set, we need to use the
animation's timing function.
	
Fixed also a bug in passing the duration to solveCubicBezierFunction. The
duration was divided two times by 1000 and meanwhile casted to int. It needs to
be kept as double and divided by 1000 only once.


More information about the webkit-reviews mailing list