[webkit-reviews] review denied: [Bug 36454] Improve reporting of frame loader callbacks in DRT : [Attachment 51317] Add a CR after printing didFinishDocumentLoadForFram

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 25 01:53:33 PDT 2010


Eric Seidel <eric at webkit.org> has denied Sergio Villar Senin
<svillar at igalia.com>'s request for review:
Bug 36454: Improve reporting of frame loader callbacks in DRT
https://bugs.webkit.org/show_bug.cgi?id=36454

Attachment 51317: Add a CR after printing didFinishDocumentLoadForFram
https://bugs.webkit.org/attachment.cgi?id=51317&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Change again looks OK, but ChangeLog needs work.  see
http://webkit.org/coding/contributing.html.

ChangeLogs are important both for the review of patches, and for when other
people wish to understand what your code does (during svn annotate, etc.)


More information about the webkit-reviews mailing list