[webkit-reviews] review denied: [Bug 36533] Compilation error on Qt for Embedded Linux built with -qconfig small : [Attachment 51504] add #ifndef QT_NO_SETTINGS ~ #endif

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 24 23:43:25 PDT 2010


Eric Seidel <eric at webkit.org> has denied tasuku.suzuki at nokia.com's request for
review:
Bug 36533: Compilation error on Qt for Embedded Linux built with -qconfig small
https://bugs.webkit.org/show_bug.cgi?id=36533

Attachment 51504: add #ifndef QT_NO_SETTINGS ~ #endif
https://bugs.webkit.org/attachment.cgi?id=51504&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
This seems specific to inspector settings. Why woudl it be called NO_SETTINGS? 
I expected this to deal with Settings.h  Please explain what you're tryign to
do in the ChangeLog.


More information about the webkit-reviews mailing list