[webkit-reviews] review denied: [Bug 36526] Compilation error on Qt for Embedded Linux built with -qconfig large : [Attachment 51491] add #ifndef QT_NO_PROPERTIES ~ #endif

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 24 23:36:09 PDT 2010


Eric Seidel <eric at webkit.org> has denied tasuku.suzuki at nokia.com's request for
review:
Bug 36526: Compilation error on Qt for Embedded Linux built with -qconfig large
https://bugs.webkit.org/show_bug.cgi?id=36526

Attachment 51491: add #ifndef QT_NO_PROPERTIES ~ #endif
https://bugs.webkit.org/attachment.cgi?id=51491&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Why?  I don't understand why we want this change.

What is this intending to disable?  If it's qt-specific, why are changes
required to the common files?
+#ifndef QT_NO_PROPERTIES
     PassScriptInstance createScriptInstanceForWidget(Widget*);
+#endif


More information about the webkit-reviews mailing list