[webkit-reviews] review granted: [Bug 36578] [chromium] update chromium DEPS for upstream compile : [Attachment 51594] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 24 22:28:30 PDT 2010


Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted Tony Chang
(Google) <tony at chromium.org>'s request for review:
Bug 36578: [chromium] update chromium DEPS for upstream compile
https://bugs.webkit.org/show_bug.cgi?id=36578

Attachment 51594: Patch
https://bugs.webkit.org/attachment.cgi?id=51594&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
> +++ b/WebKit/chromium/DEPS

> +   'third_party/wtl':
> +	Var('chromium_svn')+'/third_party/wtl@'+Var('chromium_rev'),

can we avoid the wtl dependencies?

would it be possible for some of these dependencies to be expressed
through a GYP variable that is defined within the chromium repository?

it seems like it would be very nice if chromium/DEPS only mentioned
the things that are directly used by WebKit.  then, if we could
somehow infer the dependencies that those things require, we could
greatly minimize what gets hard coded into chromium/DEPS.  That
would help minimize the cost associated with changing the set of
dependencies.

R=me all the same


More information about the webkit-reviews mailing list