[webkit-reviews] review denied: [Bug 36545] [Chromium] Add an ASSERT macro to the Chromium WebKit API : [Attachment 51522] Patch

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied Jeremy Orlow
<jorlow at chromium.org>'s request for review:
Bug 36545: [Chromium] Add an ASSERT macro to the Chromium WebKit API
https://bugs.webkit.org/show_bug.cgi?id=36545

Attachment 51522: Patch
https://bugs.webkit.org/attachment.cgi?id=51522&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
> +++ b/WebKit/chromium/public/WebCommon.h
...
>  } // namespace WebKit
>  
> +//
-----------------------------------------------------------------------------
> +// Assertions
> +
> +namespace WebKit {
> +
> +void failedAssertion(const char* file, int line, const char* function, const
char* assertion);
> +
> +} // namespace WebKit

Why close and then re-open the WebKit namespace?

Please annotate WebKit API entry points with WEBKIT_API.


> +// Only use inside the public directory but outside of WEBKIT_IMPLEMENTATION
blocks.  Otherwise use WTF's ASSERT.

There is actually no problem using this outside of WEBKIT_IMPLEMENTATION
blocks.


> +#if defined(NDEBUG)
> +#define WEBKIT_ASSERT(assertion) ((void)0)
> +#else
> +#define WEBKIT_ASSERT(assertion) do \
> +    if (!(assertion)) { \
> +	   WebKit::failedAssertion(__FILE__, __LINE__, __FUNCTION__,
#assertion); \
> +    } \

^^^ nit: webkit style says no brackets around single line statements.