[webkit-reviews] review denied: [Bug 26927] webkit-patch or pre-commit hook should validate reviewer lines before committing : [Attachment 51586] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied Adam Barth <abarth at webkit.org>'s
request for review:
Bug 26927: webkit-patch or pre-commit hook should validate reviewer lines
before committing
https://bugs.webkit.org/show_bug.cgi?id=26927

Attachment 51586: Patch
https://bugs.webkit.org/attachment.cgi?id=51586&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
+	 os.chdir(self._tool.scm().checkout_root)

That needs a FIXME.

Can we say regexp?
+	     if changelog_entry.contents().lower().find("unreviewed"):

re.match("unreviewed", changelog_entry.contents(), re.IGNORECASE)

You could/should even just compile the regexp as a class variable on
ValidateReviewer.

+	     error('%s neither lists a valid reviewer nor contains the string
"Unreviewed".')
should note that the search is case insensitive.

I am saddened by the lack of the testzors.

Otherwise this looks great!