[webkit-reviews] review denied: [Bug 26927] webkit-patch or pre-commit hook should validate reviewer lines before committing : [Attachment 51572] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 24 19:24:13 PDT 2010


Eric Seidel <eric at webkit.org> has denied Adam Barth <abarth at webkit.org>'s
request for review:
Bug 26927: webkit-patch or pre-commit hook should validate reviewer lines
before committing
https://bugs.webkit.org/show_bug.cgi?id=26927

Attachment 51572: Patch
https://bugs.webkit.org/attachment.cgi?id=51572&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
You are a better man than I.  However, this is sub-optimal (and will break the
case of the ChangeLog posted already having a valid reviewer).

Better would be to look at reviewer() on all the ChangeLogEntries right before
we assemble the commit message.  We could even validate that that reviewer()
matches the one we pulled off the bug, if the bug had one.


More information about the webkit-reviews mailing list