[webkit-reviews] review requested: [Bug 36572] commit-log-editor: thinks mergeChangeLogs.pl is a ChangeLog file : [Attachment 51577] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 24 18:54:44 PDT 2010


David Kilzer (ddkilzer) <ddkilzer at webkit.org> has asked  for review:
Bug 36572: commit-log-editor: thinks mergeChangeLogs.pl is a ChangeLog file
https://bugs.webkit.org/show_bug.cgi?id=36572

Attachment 51577: Patch
https://bugs.webkit.org/attachment.cgi?id=51577&action=review

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
Reviewed by NOBODY (OOPS!).

Fixes the following error when committing a file with
"ChangeLog" in the name that isn't a ChangeLog (like
mergeChangeLogs.pl from r56471 and r56472):

$ git commit .
Can't open WebKitTools/Scripts/webkitperl/VCSUtils_unittest/mergeChangeLog at
commit-log-editor line 132.
error: There was a problem with the editor 'commit-log-editor'.
Please supply the message using either -m or -F option.

* Scripts/commit-log-editor: Added '$' to anchor "ChangeLog" to
the end of the file name when searching for ChangeLog files in a
commit.
---
 2 files changed, 20 insertions(+), 1 deletions(-)


More information about the webkit-reviews mailing list