[webkit-reviews] review granted: [Bug 36556] CSSPrimitiveValue::cssText() is slow : [Attachment 51554] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 24 15:17:03 PDT 2010


Darin Adler <darin at apple.com> has granted Stephen White
<senorblanco at chromium.org>'s request for review:
Bug 36556: CSSPrimitiveValue::cssText() is slow
https://bugs.webkit.org/show_bug.cgi?id=36556

Attachment 51554: Patch
https://bugs.webkit.org/attachment.cgi?id=51554&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
Needs at least one test for each of the places where you had to clear
m_cachedCSSText that would fail if you hadn't cleared out m_cachedCSSText. Can
I comment out any one of the lines that set m_cachedCSSText and see a test
fail?

It would be nice to make the caching work for FontFamilyValue, too.

r=me


More information about the webkit-reviews mailing list