[webkit-reviews] review granted: [Bug 36530] Web Inspector: Error when highlighting JavaScript with an invalid mime type : [Attachment 51497] [PATCH] Proposed solution
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Mar 24 08:08:45 PDT 2010
Pavel Feldman <pfeldman at chromium.org> has granted Alexander Pavlov (apavlov)
<apavlov at chromium.org>'s request for review:
Bug 36530: Web Inspector: Error when highlighting JavaScript with an invalid
mime type
https://bugs.webkit.org/show_bug.cgi?id=36530
Attachment 51497: [PATCH] Proposed solution
https://bugs.webkit.org/attachment.cgi?id=51497&action=review
------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
+ if (resource.mimeTypeIsConsistentWithType())
If this thing returns true, we still might end up with no tokenizer. Should
this code be moved to the SourceTokenizer where you could handle this case?
More information about the webkit-reviews
mailing list