[webkit-reviews] review requested: [Bug 36482] Regression(r55766): [Chromium] chromiumDataObject.hasData() reports true for an empty clipboard : [Attachment 51487] patch - complete rewrite, put code into ChromiumDataObject, retain input uri-list string

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 24 03:47:15 PDT 2010


Roland Steiner <rolandsteiner at chromium.org> has asked  for review:
Bug 36482: Regression(r55766): [Chromium] chromiumDataObject.hasData() reports
true for an empty clipboard
https://bugs.webkit.org/show_bug.cgi?id=36482

Attachment 51487: patch - complete rewrite, put code into ChromiumDataObject,
retain input uri-list string
https://bugs.webkit.org/attachment.cgi?id=51487&action=review

------- Additional Comments from Roland Steiner <rolandsteiner at chromium.org>
I guess it's better to re-write the code after all:

.) Put the processing code into ChromiumDataObject, removed the friend clause,
replaced the code in ClipboardChromium with one-liners.
.) Added a layout test (skipped on all platforms besides Chromium)

This change also goes towards MIME-type handling, in that the input uri-list is
no longer stored as a vector, but as a simple string.
It is returned verbatim on getData("text/uri-list"). The code still extracts
the first valid URL within that string (may be empty) and will return that on
getData("URL").


More information about the webkit-reviews mailing list