[webkit-reviews] review granted: [Bug 36426] Chromium: Crash in WebCore::ArchiveFactory::isArchiveMimeType : [Attachment 51483] ASSERT() -> CRASH()

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 24 02:54:32 PDT 2010


Jeremy Orlow <jorlow at chromium.org> has granted Jeremy Moskovich
<playmobil at google.com>'s request for review:
Bug 36426: Chromium: Crash in WebCore::ArchiveFactory::isArchiveMimeType
https://bugs.webkit.org/show_bug.cgi?id=36426

Attachment 51483: ASSERT() -> CRASH()
https://bugs.webkit.org/attachment.cgi?id=51483&action=review

------- Additional Comments from Jeremy Orlow <jorlow at chromium.org>
We really need some sort of "always assert...even outside of debug mode"
assert.  I thought one existed, but I can't find it.

r=me but please do a follow up patch to add such an assert and convert this
code to it.  cc maciej, darin, and sam since it's quite likely they'll have an
opinion on it.


More information about the webkit-reviews mailing list