[webkit-reviews] review requested: [Bug 36426] Chromium: Crash in WebCore::ArchiveFactory::isArchiveMimeType : [Attachment 51483] ASSERT() -> CRASH()

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 24 01:10:23 PDT 2010


Jeremy Moskovich <playmobil at google.com> has asked  for review:
Bug 36426: Chromium: Crash in WebCore::ArchiveFactory::isArchiveMimeType
https://bugs.webkit.org/show_bug.cgi?id=36426

Attachment 51483: ASSERT() -> CRASH()
https://bugs.webkit.org/attachment.cgi?id=51483&action=review

------- Additional Comments from Jeremy Moskovich <playmobil at google.com>
* ASSERT() is disabled in release builds so call CRASH() explicitly.  This
matches other places in WebKit where CRASH() is used for fatal errors.
* Fix Nits


More information about the webkit-reviews mailing list