[webkit-reviews] review denied: [Bug 36195] Add layout test flakiness (diagnostics) dashboard to TestResultServer appengine : [Attachment 51466] Proposed Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Mar 24 00:41:18 PDT 2010
Adam Barth <abarth at webkit.org> has denied Victor Wang <victorw at chromium.org>'s
request for review:
Bug 36195: Add layout test flakiness (diagnostics) dashboard to
TestResultServer appengine
https://bugs.webkit.org/show_bug.cgi?id=36195
Attachment 51466: Proposed Patch
https://bugs.webkit.org/attachment.cgi?id=51466&action=review
------- Additional Comments from Adam Barth <abarth at webkit.org>
+ self.response.out.write(files[0].data)
Mime type? Character set?
+ self.response.out.write("\n".join(errors))
XSS?
+ DashboardFile.delete_file(file)
CSRF? Public delete file URL?
+ http://src.chromium.org/
Wrong project?
+ url = SVN_PATH_DASHBOARD + name
URL encoding?
Tests???
More information about the webkit-reviews
mailing list