[webkit-reviews] review granted: [Bug 36486] Web Inspector: render nodes in inherited style bars as links. : [Attachment 51411] [PATCH] Proposed change.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 23 07:24:36 PDT 2010


Timothy Hatcher <timothy at hatcher.name> has granted Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 36486: Web Inspector: render nodes in inherited style bars as links.
https://bugs.webkit.org/show_bug.cgi?id=36486

Attachment 51411: [PATCH] Proposed change.
https://bugs.webkit.org/attachment.cgi?id=51411&action=review

------- Additional Comments from Timothy Hatcher <timothy at hatcher.name>

> +		       var nodeClass = styleRule.node.getAttribute("class");
> +		       if (nodeClass)
> +			   title += "." + nodeClass;
> +		       var nodeId = styleRule.node.getAttribute("id");
> +		       if (nodeId)
> +			   title += "#" + nodeId;

We should make this a helper function, I think we do this in another place when
making a new style rule and breadcrumbs.


More information about the webkit-reviews mailing list