[webkit-reviews] review requested: [Bug 36213] Assertion failure when inspecting a page with workers : [Attachment 51421] Send worker creation/destruction notifications to inspector frontend asynchronously

[bugzilla-daemon at webkit.org]

Andrey Kosyakov <caseq at chromium.org> has asked	for review:
Bug 36213: Assertion failure when inspecting a page with workers
https://bugs.webkit.org/show_bug.cgi?id=36213

Attachment 51421: Send worker creation/destruction notifications to inspector
frontend asynchronously
https://bugs.webkit.org/attachment.cgi?id=51421&action=review

------- Additional Comments from Andrey Kosyakov <caseq at chromium.org>
Dmitry,
thanks for the feedback! I've implemented most of your recommendations with the
exception of "long long" for IDs in InjectedScriptHost -- the idea is, these
IDs are for a different type of workers actually -- the "fake" ones,
implemented in JS, that we inject when user attempts to debug workers. These
IDs never store anything that we get from AbstractWorker::asID() and are rather
generated on the inspector side (InjectedScriptHost::nextWorkerId()), so their
life-cycle is 
InjectedScriptHost -> JS fake workers implementation -> InspectorController ->
InspectorFrontend and hence they need to use an integral type that is not wider
than one used in InsectorController & InspectorFrontend. Using long long would
actually cause truncation on 32-bit platforms (assuming sizeof(intptr_t) == 4
&& sizeof(long long) == 8). This is still a bit fishy for the case of
sizeof(long) > sizeof(intptr_t), but I believe it only happens on 16 bit
platforms, so we hardly care.