[webkit-reviews] review granted: [Bug 36398] [GTK] Does not build with latest GTK+ development release : [Attachment 51381] proposed fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 23 01:35:04 PDT 2010


Holger Freyther <zecke at selfish.org> has granted Gustavo Noronha (kov)
<gns at gnome.org>'s request for review:
Bug 36398: [GTK] Does not build with latest GTK+ development release
https://bugs.webkit.org/show_bug.cgi?id=36398

Attachment 51381: proposed fix
https://bugs.webkit.org/attachment.cgi?id=51381&action=review

------- Additional Comments from Holger Freyther <zecke at selfish.org>
Mostly fine, we will just ignore the style warning as we want to keep the
mozilla code mergable.


> -    /* only paint widgets with NO_WINDOW this way */
> -    if (!GTK_WIDGET_NO_WINDOW(platformWidget()))
> +    /* only paint widgets with no window this way */
> +    if (!!gtk_widget_get_has_window(platformWidget()))
>	   return;

You can just remove the '!'?!


More information about the webkit-reviews mailing list