[webkit-reviews] review denied: [Bug 36477] webkit-patch reads wrong bug url from unified diff context : [Attachment 51393] patch v0

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 22 22:47:48 PDT 2010


Eric Seidel <eric at webkit.org> has denied MORITA Hajime <morrita at google.com>'s
request for review:
Bug 36477: webkit-patch reads wrong bug url from unified diff context
https://bugs.webkit.org/show_bug.cgi?id=36477

Attachment 51393: patch v0
https://bugs.webkit.org/attachment.cgi?id=51393&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
This is the wrong fix.	In this case you want to just use the code for pulling
the bug from the ChangeLogEntry instead of the diff.  This proposed change
would still wrongly grab bug urls added in other parts of the diff besides the
ChangeLog.

I recently added a ChangeLogEntry class which exposes a bug_id() method which
should fix this case.


More information about the webkit-reviews mailing list