[webkit-reviews] review denied: [Bug 36472] Add support to create UUID string. : [Attachment 51374] Proposed Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 22 18:15:09 PDT 2010


Darin Adler <darin at apple.com> has denied Jian Li <jianli at chromium.org>'s
request for review:
Bug 36472: Add support to create UUID string.
https://bugs.webkit.org/show_bug.cgi?id=36472

Attachment 51374: Proposed Patch
https://bugs.webkit.org/attachment.cgi?id=51374&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
This does not belong in the String class's header file. You should give it its
own header file unless you can find some other functions it belongs with.

The code to make the strings seems OK. but the opening function brace should be
on its own line. Also, we normally put separate functions per platform into
separate source files instead of adding them all to one file.


More information about the webkit-reviews mailing list