[webkit-reviews] review denied: [Bug 36460] Implement Show/Hide Controls command for <video> in chromium : [Attachment 51350] Patch

[bugzilla-daemon at webkit.org]

Dmitry Titov <dimich at chromium.org> has denied Sergey Ulanov
<sergeyu at chromium.org>'s request for review:
Bug 36460: Implement Show/Hide Controls command for <video> in chromium
https://bugs.webkit.org/show_bug.cgi?id=36460

Attachment 51350: Patch
https://bugs.webkit.org/attachment.cgi?id=51350&action=review

------- Additional Comments from Dmitry Titov <dimich at chromium.org>
> diff --git a/WebKit/chromium/ChangeLog b/WebKit/chromium/ChangeLog
> +
> +	   Show/Hide Controls command for <video>
> +
> +	   https://bugs.webkit.org/show_bug.cgi?id=36460

these 2 lines usually do not have empty line between them.

Also, typically bugs and good ChangeLogs contain a bit more info, as to why and
what was changed. It helps other folks when they 'scan' trac database or search
bugzilla (or sometimes try to glean more information in an attempt to fix a bug
that seems to be caused by the change). Look at existing entries that describe
a change in a way that give you a good understanding of why and what has
changed.

Since you are not a committer yet, I think you'd want to use a commit-bot. It
runs compile and tests and lands the patch once it is approved. In order to use
it, you flip the commit-queue flag to ?, so the reviewer knows you want to use
it and flips it to + with r+.

Doing r- for now, looking forward for more info in ChangeLog, looks ok in
general.