[webkit-reviews] review granted: [Bug 36465] window.Document !== window.XMLDocument : [Attachment 51368] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 36465: window.Document !== window.XMLDocument
https://bugs.webkit.org/show_bug.cgi?id=36465

Attachment 51368: Patch
https://bugs.webkit.org/attachment.cgi?id=51368&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> -    static PassRefPtr<Document> createDocument(Frame*);
> +    static PassRefPtr<XMLDocument> createDocument(Frame*);

I think we should get rid of DOMImplementation::createDocument and
DOMImplementation::createHTMLDocument. I can't find any callers of either
function.

> +    static PassRefPtr<Document> createXHTML(Frame* frame)
> +    {
> +	   return adoptRef(new XMLDocument(frame, true));
> +    }

Return type here should be PassRefPtr<XMLDocument>.

> +    XMLDocument(Frame* frame, bool isXHTML);

This should be private; it is only called from the static member functions
above.

> +    virtual ~XMLDocument();

This isn't needed at all. We should leave it out.

> --- a/WebCore/xml/XMLHttpRequest.cpp
> +++ b/WebCore/xml/XMLHttpRequest.cpp
> @@ -41,6 +41,7 @@
>  #include "Settings.h"
>  #include "TextResourceDecoder.h"
>  #include "ThreadableLoader.h"
> +#include "XMLDocument.h"

We should also remove the include of "Document.h".