[webkit-reviews] review denied: [Bug 36444] [Qt] LayoutTests/fast/canvas/fillrect_gradient.html failed : [Attachment 51312] fix platformGradient
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Mar 22 15:18:17 PDT 2010
Simon Hausmann <hausmann at webkit.org> has denied qi <qi.2.zhang at nokia.com>'s
request for review:
Bug 36444: [Qt] LayoutTests/fast/canvas/fillrect_gradient.html failed
https://bugs.webkit.org/show_bug.cgi?id=36444
Attachment 51312: fix platformGradient
https://bugs.webkit.org/attachment.cgi?id=51312&action=review
------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
> + std::sort(m_stops.begin(), m_stops.end(), stopColorSortPredicate);
I think you should use Gradient::sortStopsIfNecessary() here instead.
The rest looks good to me. r- for the above.
More information about the webkit-reviews
mailing list