[webkit-reviews] review granted: [Bug 36328] Missing plug-ins should be represented by text only, instead of lego block : [Attachment 51361] 51352: Eliminate WebNullPluginView from Mac OS X WebKit

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 22 15:03:43 PDT 2010


Simon Fraser (smfr) <simon.fraser at apple.com> has granted Kevin Decker
<kdecker at apple.com>'s request for review:
Bug 36328: Missing plug-ins should be represented by text only, instead of lego
block
https://bugs.webkit.org/show_bug.cgi?id=36328

Attachment 51361: 51352: Eliminate WebNullPluginView from Mac OS X WebKit
https://bugs.webkit.org/attachment.cgi?id=51361&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
> Index: WebCore/ChangeLog
> ===================================================================
> --- WebCore/ChangeLog (revision 56360)
> +++ WebCore/ChangeLog (working copy)
> @@ -1,3 +1,21 @@
> +2010-03-22  Kevin Decker  <kdecker at apple.com>
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   https://bugs.webkit.org/show_bug.cgi?id=36328
> +
> +	   * rendering/RenderEmbeddedObject.cpp:
> +	   (WebCore::RenderEmbeddedObject::RenderEmbeddedObject): Fix a
find/repalce mistake from my earlier patrch.

2 typos on that line.

> +	   (WebCore::RenderEmbeddedObject::paint):Fix a find/repalce mistake
from my earlier patrch.

Ditto.

r=me


More information about the webkit-reviews mailing list