[webkit-reviews] review denied: [Bug 36395] [Qt] Patch to add support for Content-Disposition... : [Attachment 51235] Alternate patch as described in the original report...

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 22 14:55:24 PDT 2010


Simon Hausmann <hausmann at webkit.org> has denied adawit at kde.org's request for
review:
Bug 36395: [Qt] Patch to add support for Content-Disposition...
https://bugs.webkit.org/show_bug.cgi?id=36395

Attachment 51235: Alternate patch as described in the original report...
https://bugs.webkit.org/attachment.cgi?id=51235&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
This patch is also missing a ChangeLog.

My main issue with it is that the reply isn't cancelled if the application
forgets to connect to the right overloaded(!) signal.

Despite the goal of mapping the attachment to a download, I think the approach
of is more confusing that the first patch.


More information about the webkit-reviews mailing list