[webkit-reviews] review granted: [Bug 34477] [Qt] Canvas createPattern with no-repeat not working : [Attachment 51348] new patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Mar 22 14:40:23 PDT 2010
Simon Hausmann <hausmann at webkit.org> has granted qi <qi.2.zhang at nokia.com>'s
request for review:
Bug 34477: [Qt] Canvas createPattern with no-repeat not working
https://bugs.webkit.org/show_bug.cgi?id=34477
Attachment 51348: new patch
https://bugs.webkit.org/attachment.cgi?id=51348&action=review
------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
> + bool repeatX() { return m_repeatX; }
> + bool repeatY() { return m_repeatY; }
Both methods should be const. Please fix before landing.
The rest looks good to me.
More information about the webkit-reviews
mailing list