[webkit-reviews] review granted: [Bug 35870] Upstream iPhone KeyEvent platform code and share with Mac platform : [Attachment 50450] [PATCH] Part 2 - Move Mac Code into Shared Location (no change to code itself yet)

[bugzilla-daemon at webkit.org]

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has granted Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 35870: Upstream iPhone KeyEvent platform code and share with Mac platform
https://bugs.webkit.org/show_bug.cgi?id=35870

Attachment 50450: [PATCH] Part 2 - Move Mac Code into Shared Location (no
change to code itself yet)
https://bugs.webkit.org/attachment.cgi?id=50450&action=review

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
> diff --git a/WebCore/platform/cocoa/KeyEventCocoa.h
b/WebCore/platform/cocoa/KeyEventCocoa.h
> new file mode 100644
> index 0000000..fe1d660
> --- /dev/null
> +++ b/WebCore/platform/cocoa/KeyEventCocoa.h
> +#ifndef KeyEventCocoa_h
> +#define KeyEventCocoa_h
> [...]
> +#endif // !KeyEventCocoa_h

Nit:  usually we don't use a "!" in this comment for headers.  Darin Adler
mentioned on webkit-dev that this comment is unnecessary, so you may optionally
remove it.

Thanks for using an "svn mv" to create the KeyEventCocoa.mm file!

r=me