[webkit-reviews] review requested: [Bug 36312] Support viewport meta tag : [Attachment 51332] Patch 1 of 2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 22 12:31:52 PDT 2010


Daniel Bates <dbates at webkit.org> has asked  for review:
Bug 36312: Support viewport meta tag
https://bugs.webkit.org/show_bug.cgi?id=36312

Attachment 51332: Patch 1 of 2
https://bugs.webkit.org/attachment.cgi?id=51332&action=review

------- Additional Comments from Daniel Bates <dbates at webkit.org>
Renamed method receiveViewportArguments to dispatchDidReceiveViewportArguments
to be more descriptive and to conform to the naming conventions for similar
methods in FrameLoaderClient. Added #ifdef/#endif META_VIEWPORT guard around
#include ViewportArguments.h  and forward declaration in files
WebCore/dom/Document.cpp and WebCore/loader/FrameLoaderClient.h,
respectively.Fixed some style issues that the style bot missed.


More information about the webkit-reviews mailing list