[webkit-reviews] review requested: [Bug 36414] Web Inspector: display CSS selector source line in the styles sidebar pane. : [Attachment 51330] [PATCH] Proposed change that does not regress performance.

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has asked  for review:
Bug 36414: Web Inspector: display CSS selector source line in the styles
sidebar pane.
https://bugs.webkit.org/show_bug.cgi?id=36414

Attachment 51330: [PATCH] Proposed change that does not regress performance.
https://bugs.webkit.org/attachment.cgi?id=51330&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
There was an 8% performance regression in the original patch caused by the
bison's token location handling code. As soon as I started using @1.first_line,
whole yylloc thing was starting to make things slower. I went back the the
location-less parsing, but inserted updateLocation calls into the selector
rules. At the moment of their action triggering, lexer is at the '{' token
which is exactly where we want to end up upon navigation. Updated patch does
not regress performance, I was testing it on a 4Mb concatenated CSS taken from
chromium page cyclers.