[webkit-reviews] review canceled: [Bug 36168] Spatial Navigation: Code simplification in FocusController.cpp and SpatialNavigation.cpp : [Attachment 51285] patch_2 - v1 - code simplification

[bugzilla-daemon at webkit.org]

Antonio Gomes (tonikitoo) <tonikitoo at webkit.org> has canceled Antonio Gomes
(tonikitoo) <tonikitoo at webkit.org>'s request for review:
Bug 36168: Spatial Navigation: Code simplification in FocusController.cpp and
SpatialNavigation.cpp
https://bugs.webkit.org/show_bug.cgi?id=36168

Attachment 51285: patch_2 - v1 - code simplification
https://bugs.webkit.org/attachment.cgi?id=51285&action=review

------- Additional Comments from Antonio Gomes (tonikitoo)
<tonikitoo at webkit.org>
(In reply to comment #15)
> Attachment 51285 [details] did not build on mac:
> Build output: http://webkit-commit-queue.appspot.com/results/978125

I talked to Eric and he clarified the Mac build problem:

"The problem here is that you've made FocusController (a header file
which is exposed privately from WebCore to WebKit) depend on
SpatialNavigation.h w/o also exposing SpatialNavigation.h.

Do you have to make it depend on the header?  You can definitely mark
SpatialNavigation as a "private" header, instead of "project" as it
defaults to, and then the build will work, but itmight be easier to
just avoid the header spawl all together."


clearing review as I will address it now.