[webkit-reviews] review granted: [Bug 35870] Upstream iPhone KeyEvent platform code and share with Mac platform : [Attachment 50449] [PATCH] Part 1 - Upstream iPhone Code (unused so far)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 22 12:13:28 PDT 2010


David Kilzer (ddkilzer) <ddkilzer at webkit.org> has granted Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 35870: Upstream iPhone KeyEvent platform code and share with Mac platform
https://bugs.webkit.org/show_bug.cgi?id=35870

Attachment 50449: [PATCH] Part 1 - Upstream iPhone Code (unused so far)
https://bugs.webkit.org/attachment.cgi?id=50449&action=review

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
> diff --git a/WebCore/platform/iphone/KeyEventCodesIPhone.h
b/WebCore/platform/iphone/KeyEventCodesIPhone.h
> +	NSUpArrowFunctionKey		= 0xF700,

Please change the tabs to spaces in the header file to correct the style
issues.

r=me


More information about the webkit-reviews mailing list