[webkit-reviews] review requested: [Bug 34922] Mingw-w64 fixes for QtWebKit (WebCore and JavaScriptCore) : [Attachment 51313] patch with fixes required by QtWebkit for mingw64 -v3

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 22 11:18:40 PDT 2010


vanboxem.ruben at gmail.com has asked  for review:
Bug 34922: Mingw-w64 fixes for QtWebKit (WebCore and JavaScriptCore)
https://bugs.webkit.org/show_bug.cgi?id=34922

Attachment 51313: patch with fixes required by QtWebkit for mingw64 -v3
https://bugs.webkit.org/attachment.cgi?id=51313&action=review

------- Additional Comments from vanboxem.ruben at gmail.com
the line breaks have been removed.

firstly: uword is used here for pointer casts, which makes uintptr_t a good
replacement
secondly: unsigned long in 32-bit in 32-bit and 64-bit windows, so that makes
it a bad choice for this situation.


More information about the webkit-reviews mailing list