[webkit-reviews] review granted: [Bug 36424] Web Inspector: AuditRules still use getMatchedCSSRules as a part of the img-related audit. : [Attachment 51305] [PATCH] Comments addressed

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 22 11:05:58 PDT 2010


Pavel Feldman <pfeldman at chromium.org> has granted Alexander Pavlov (apavlov)
<apavlov at chromium.org>'s request for review:
Bug 36424: Web Inspector: AuditRules still use getMatchedCSSRules as a part of
the img-related audit.
https://bugs.webkit.org/show_bug.cgi?id=36424

Attachment 51305: [PATCH] Comments addressed
https://bugs.webkit.org/attachment.cgi?id=51305&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
r+ with nits, please fix before landing.

> +	       var widthFound, heightFound;

No need for these to live for so long - just declare them when assigning.

> +		   var nodeId = this.pushNodePathToFrontend(nodes[i]);

I'd call this new method 'getNodeId'


More information about the webkit-reviews mailing list