[webkit-reviews] review denied: [Bug 35090] Need -webkit-focus-inner to control the style of buttons : [Attachment 48999] Patch v1
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Mar 22 10:13:49 PDT 2010
Adam Barth <abarth at webkit.org> has denied Shinichiro Hamaji
<hamaji at chromium.org>'s request for review:
Bug 35090: Need -webkit-focus-inner to control the style of buttons
https://bugs.webkit.org/show_bug.cgi?id=35090
Attachment 48999: Patch v1
https://bugs.webkit.org/attachment.cgi?id=48999&action=review
------- Additional Comments from Adam Barth <abarth at webkit.org>
Your ChangeLog doesn't give any information about this change.
I didn't understand why this part was necessary:
-void RenderButton::setupInnerStyle(RenderStyle* innerStyle)
+void RenderButton::setupInnerStyle()
This patch has been up for review for over a month with no discussion.
Why do we want to implement this non-standard feature? Doesn't that just serve
to fragment the web platform? Is this a feature that we'd like to see
standardized at some point?
More information about the webkit-reviews
mailing list