[webkit-reviews] review denied: [Bug 34922] Mingw-w64 fixes for QtWebKit (WebCore and JavaScriptCore) : [Attachment 48905] patch with fixes required by QtWebkit for mingw64 -v3
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Mar 22 09:16:28 PDT 2010
Adam Barth <abarth at webkit.org> has denied vanboxem.ruben at gmail.com's request
for review:
Bug 34922: Mingw-w64 fixes for QtWebKit (WebCore and JavaScriptCore)
https://bugs.webkit.org/show_bug.cgi?id=34922
Attachment 48905: patch with fixes required by QtWebkit for mingw64 -v3
https://bugs.webkit.org/attachment.cgi?id=48905&action=review
------- Additional Comments from Adam Barth <abarth at webkit.org>
+ #elif OS(WINDOWS) && CPU(X86_64) \
No need for a line break here. (Several instances of this comment.)
- typedef unsigned long uword;
+ typedef uintptr_t uword;
Are you sure this change is correct? It would seem to have effects beyond
Mingw-w64. Similarly, uint32 => uintptr_t.
More information about the webkit-reviews
mailing list