[webkit-reviews] review granted: [Bug 36185] SVGResourceMarker needs to be moved to RenderersSVGResourceMarker : [Attachment 50831] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Mar 21 11:59:55 PDT 2010


Nikolas Zimmermann <zimmermann at kde.org> has granted Dirk Schulze
<krit at webkit.org>'s request for review:
Bug 36185: SVGResourceMarker needs to be moved to RenderersSVGResourceMarker
https://bugs.webkit.org/show_bug.cgi?id=36185

Attachment 50831: patch
https://bugs.webkit.org/attachment.cgi?id=50831&action=review

------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
Looks great! I guess you've updated all marker test results, if that's true I'm
slightly worried that we never test angle != 0.0.
Though that doesn't block the patch, so r=me. Can you have a look at non-zero
marker angles and create a testcase (safe to do afterwards...)
r=me.


More information about the webkit-reviews mailing list