[webkit-reviews] review granted: [Bug 36168] Spatial Navigation: Code simplification in FocusController.cpp and SpatialNavigation.cpp : [Attachment 51232] patch_1 v0.1 - making use of isNull and document methods.

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Antonio Gomes
(tonikitoo) <tonikitoo at webkit.org>'s request for review:
Bug 36168: Spatial Navigation: Code simplification in FocusController.cpp and
SpatialNavigation.cpp
https://bugs.webkit.org/show_bug.cgi?id=36168

Attachment 51232: patch_1 v0.1 - making use of isNull and document methods.
https://bugs.webkit.org/attachment.cgi?id=51232&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
Why is this patch called v0.1? Is this not the final one that you are
submitting for review?

>      if (alignment != None
> -	   || (candidate.node && candidate.parentAlignment >= alignment
> -	   && (candidate.node->document() == dest->document())
> -	   && alignment > None)) {
> +	   || (!candidate.isNull() && candidate.parentAlignment >= alignment
> +	   && candidate.document() == dest->document())) {
>  

Is it possible to refactor code to bail out earlier if the alignment or the
candidate is null?