[webkit-reviews] review denied: [Bug 36381] webkit w/ icu-4.4: TextBreakIteratorICU.cpp error cannot convert WebCore TextBreakIterator to UBreakIterator : [Attachment 51230] webkit-icu-4.4.patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Priit Laes (IRC: plaes)
<plaes at plaes.org>'s request for review:
Bug 36381: webkit w/ icu-4.4: TextBreakIteratorICU.cpp error cannot convert
WebCore TextBreakIterator to UBreakIterator
https://bugs.webkit.org/show_bug.cgi?id=36381

Attachment 51230: webkit-icu-4.4.patch
https://bugs.webkit.org/attachment.cgi?id=51230&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
Fixing this should not require any changes to the header file. The changes
should be inside TextBreakIteratorICU.cpp with no changes to header files.

Since ICU has changed the type UBreakIterator from a void to an actual type,
the type casts involving UBreakIterator should now be reinterpret_cast rather
than static_cast.