[webkit-reviews] review requested: [Bug 36048] Detect if the Platform SDK is missing when building with Visual C++ Express Edition : [Attachment 51221] Patch

[bugzilla-daemon at webkit.org]

Daniel Bates <dbates at webkit.org> has asked  for review:
Bug 36048: Detect if the Platform SDK is missing when building with Visual C++
Express Edition
https://bugs.webkit.org/show_bug.cgi?id=36048

Attachment 51221: Patch
https://bugs.webkit.org/attachment.cgi?id=51221&action=review

------- Additional Comments from Daniel Bates <dbates at webkit.org>
Moved check for Platform SDK into subroutine buildVisualStudioProject from
subroutine setupCygwinEnv so that we only check for its existence when we are
are going to build. This resolves the issue observed on the Windows Debug
(Test) bot where run-webkit-tests is passed the --root argument and thus does
not build DRT (hence, there is no need to check for the Platform SDK).

Also, updated the criterion for determining whether the Platform SDK is
installed by checking for the existence of its registry entry instead of a
fixed install location.