[webkit-reviews] review granted: [Bug 36387] REGRESSION: Can "uncheck" radio buttons by clicking on them : [Attachment 51200] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 19 16:16:46 PDT 2010


Dimitri Glazkov (Google) <dglazkov at chromium.org> has granted Simon Fraser
(smfr) <simon.fraser at apple.com>'s request for review:
Bug 36387: REGRESSION: Can "uncheck" radio buttons by clicking on them
https://bugs.webkit.org/show_bug.cgi?id=36387

Attachment 51200: Patch
https://bugs.webkit.org/attachment.cgi?id=51200&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
r=me with nits:

> +    if (window.layoutTestController)
> +	 layoutTestController.dumpAsText();
> +
> +    function dispatchEvent(target, eventType, offsetX, offsetY)
> +    {

two-space indent? :)

> +</body>
> +</html>
> \ No newline at end of file

add extra line break.

>	       // As a way to store the state, we return 0 if we were
unchecked, 1 if we were checked, and 2 for
>	       // indeterminate.

remove that comment.



More information about the webkit-reviews mailing list