[webkit-reviews] review requested: [Bug 34888] Mac OS X: Use deployment target to determine whether memory tagging should be enabled : [Attachment 51158] Revised patch (don't crash on Leopard when targeting Tiger!)

[bugzilla-daemon at webkit.org]

Kent Hansen <kent.hansen at nokia.com> has asked  for review:
Bug 34888: Mac OS X: Use deployment target to determine whether memory tagging
should be enabled
https://bugs.webkit.org/show_bug.cgi?id=34888

Attachment 51158: Revised patch (don't crash on Leopard when targeting Tiger!)
https://bugs.webkit.org/attachment.cgi?id=51158&action=review

------- Additional Comments from Kent Hansen <kent.hansen at nokia.com>
New attempt, this time tested on Tiger/Safari build, Leopard+SnowLeopard/Qt
build.

Executive summary:
- vm_{map,allocate} on (Snow) Leopard objects to being passed tag == -1.
- mmap on Tiger objects to being passed tag != -1.
- vm_{map,allocate} on Tiger doesn't mind being passed tag != -1.
- mmap on (Snow) Leopard doesn't mind being passed tag == -1.

The patch follows from that.
It would be nice if Geoffrey Garen (and/or Mark Rowe) could take a look at
this, since he did the original vm-tags Tiger crash fix.