[webkit-reviews] review denied: [Bug 36333] [Qt] WebKit fails to build if Qt is built with QT_NO_WHEELEVENT : [Attachment 51109] Fix
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Mar 19 00:34:46 PDT 2010
Simon Hausmann <hausmann at webkit.org> has denied review:
Bug 36333: [Qt] WebKit fails to build if Qt is built with QT_NO_WHEELEVENT
https://bugs.webkit.org/show_bug.cgi?id=36333
Attachment 51109: Fix
https://bugs.webkit.org/attachment.cgi?id=51109&action=review
------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
Bero, your patch is fine in general, but it's missing a ChangeLog.
I'd also move the #ifdef _into_ the {} set, instead of creating a new set of
parentheses.
More information about the webkit-reviews
mailing list