[webkit-reviews] review requested: [Bug 36347] [chromium] querying the current HistoryItem during a back/forward navigation causes loss of scroll offset and other state : [Attachment 51131] v1 patch

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has asked  for review:
Bug 36347: [chromium] querying the current HistoryItem during a back/forward
navigation causes loss of scroll offset and other state
https://bugs.webkit.org/show_bug.cgi?id=36347

Attachment 51131: v1 patch
https://bugs.webkit.org/attachment.cgi?id=51131&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
The basic fix here is to suppress updating the current history item while we
are still loading.  I decided to exclude normal, new navigations since a user
might start interacting with the page before it is fully loaded.  Obviously,
this could be the case for other types of navigations as well, so there may be
a better overall solution.  This patch is however a significant improvement for
a pretty nasty data-loss bug.