[webkit-reviews] review granted: [Bug 9166] Setting iframe.src is not registered in history : [Attachment 51122] v1 patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Mar 19 00:14:16 PDT 2010
Adam Barth <abarth at webkit.org> has granted Darin Fisher (:fishd, Google)
<fishd at chromium.org>'s request for review:
Bug 9166: Setting iframe.src is not registered in history
https://bugs.webkit.org/show_bug.cgi?id=9166
Attachment 51122: v1 patch
https://bugs.webkit.org/attachment.cgi?id=51122&action=review
------- Additional Comments from Adam Barth <abarth at webkit.org>
Ugg. I dislike these infinite parameter lists, but I'll take care of that when
I get back to working on FrameLoader.
LGTM
+ svn:eol-style
^^ We don't usually set eol-style on tests.
We're going to have a war of fixing four-digit bugs once I get around to fixing
the Document.load bug. :)
More information about the webkit-reviews
mailing list