[webkit-reviews] review canceled: [Bug 36259] <input type=range> does not validate correctly without a renderer and the tests are incorrect : [Attachment 51083] [PATCH] Part 2 - Move Sanitization to HTMLInputElement - Fix Incorrect Tests

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 18 18:28:41 PDT 2010


Joseph Pecoraro <joepeck at webkit.org> has canceled Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 36259: <input type=range> does not validate correctly without a renderer
and the tests are incorrect
https://bugs.webkit.org/show_bug.cgi?id=36259

Attachment 51083: [PATCH] Part 2 - Move Sanitization to HTMLInputElement - Fix
Incorrect Tests
https://bugs.webkit.org/attachment.cgi?id=51083&action=review

------- Additional Comments from Joseph Pecoraro <joepeck at webkit.org>
Although I updated the tests to say that Range doesn't overflow / underflow, I
still left the code in the path where it checks for an overflow / underflow. I
moved RANGE out to the automatically false case, but I also put in an ASSERT
just in case. This also updates some comments and fixes some style issues.


More information about the webkit-reviews mailing list