[webkit-reviews] review granted: [Bug 36288] Need a layout test for finding yensign from documents with Japanese encodings : [Attachment 51014] Patch v1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 18 17:48:56 PDT 2010


Darin Adler <darin at apple.com> has granted Shinichiro Hamaji
<hamaji at chromium.org>'s request for review:
Bug 36288: Need a layout test for finding yensign from documents with Japanese
encodings
https://bugs.webkit.org/show_bug.cgi?id=36288

Attachment 51014: Patch v1
https://bugs.webkit.org/attachment.cgi?id=51014&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
In cases like this, I think that landing expected results that expect failure
is better than adding tests to the Skipped lists. We can remove the expected
failures when we fix the bug.

r=me as-is, but I'd prefer to run tests rather than skipping them


More information about the webkit-reviews mailing list