[webkit-reviews] review granted: [Bug 36337] Log an error when an OOP plug-in sends an unknown object id : [Attachment 51115] proposed patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Alexey Proskuryakov <ap at webkit.org>'s
request for review:
Bug 36337: Log an error when an OOP plug-in sends an unknown object id
https://bugs.webkit.org/show_bug.cgi?id=36337

Attachment 51115: proposed patch
https://bugs.webkit.org/attachment.cgi?id=51115&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> +	   LOG_ERROR("NetscapePluginInstanceProxy::evaluate: local object %u
doesn't exist.", objectID);

To be pedantic, %u is for printing values of type unsigned. Since objectID is
of type uint32_t the correct format string is:

    ... object " PRIu32 " doesn't ...

Of course, I'm not really sure that uint32_t is better than unsigned here. And
this can probably land as-is, but it's an example of why I think types like
uint32_t aren't all that great as abstractions.

r=me