[webkit-reviews] review denied: [Bug 36337] Log an error when an OOP plug-in sends an unknown object id : [Attachment 51112] proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 18 17:15:43 PDT 2010


Darin Adler <darin at apple.com> has denied Alexey Proskuryakov <ap at webkit.org>'s
request for review:
Bug 36337: Log an error when an OOP plug-in sends an unknown object id
https://bugs.webkit.org/show_bug.cgi?id=36337

Attachment 51112: proposed patch
https://bugs.webkit.org/attachment.cgi?id=51112&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> +	   LOG_ERROR("NetscapePluginInstanceProxy::evaluate: local object %u
doesn't exist.");

You used "%u" but forgot to pass a number. Every time!


More information about the webkit-reviews mailing list